Skip to content

Stm32f1 adc #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 13, 2025
Merged

Stm32f1 adc #582

merged 15 commits into from
Jun 13, 2025

Conversation

RecursiveError
Copy link
Contributor

No description provided.

@RecursiveError RecursiveError marked this pull request as ready for review June 4, 2025 03:52
@RecursiveError RecursiveError marked this pull request as draft June 5, 2025 01:58
@RecursiveError RecursiveError marked this pull request as ready for review June 11, 2025 23:42
Copy link
Contributor

@mattnite mattnite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is an in depth patch, great work! Btw the website has a devlog if you ever want to write a micro blog post about work you've done

@mattnite mattnite merged commit 689f4cc into ZigEmbeddedGroup:main Jun 13, 2025
44 checks passed
Comment on lines +14 to +21
@"1.5" = 0,
@"7.5" = 1,
@"13.5" = 2,
@"28.5" = 3,
@"41.5" = 4,
@"55.5" = 5,
@"71.5" = 6,
@"239.5" = 7,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should put Hz as the end of these

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is not in Hz, it is the number of ADCClock cycles.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is not in Hz, it is the number of ADCClock cycles.

Copper280z pushed a commit to Copper280z/microzig that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants