drivers: Cleanup ICM-20948 driver #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
commented
Jun 13, 2025
mattnite
approved these changes
Jun 13, 2025
Copper280z
pushed a commit
to Copper280z/microzig
that referenced
this pull request
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to push a few changes to #591 before it was merged. Mostly just cleanup, but importantly it turns off
ACCEL_CYCLE, which seems to need to be set to 0.Before #591 I had a bug in how I set the bitfields for the LP_CONFIG register, which is why I suspect setting it to 1 was OK (it was actually setting another bit).