Deduplicate Linter comments #595
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
reviewed
Jun 15, 2025
| @@ -847,3 +847,5 @@ inline fn custom_find_import_pkg_hash_or_fatal(comptime dep_name: []const u8) [] | |||
|
|
|||
| @panic("dependency not found"); | |||
| } | |||
|
|
|||
| fn myFunc() void {} | |||
There was a problem hiding this comment.
Yup, not seeing the github comment, for some reason the commits for head and the branch in the github action are the same
There was a problem hiding this comment.
is HEAD the branch in this context? vs. main?
There was a problem hiding this comment.
I thought it was supposed to be the head of main, but it's probably just the branch. I iterated a few times on this with an LLM and it seems to be falling short. I'll actually go read the docs.
mattnite
force-pushed
the
linter-dedupe-comments
branch
from
55ea0c8 to
fc04bbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.