preview fully integrated encryption #217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodh
requested changes
Feb 12, 2025
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/agent/KeyMaterial.kt
Outdated
Show resolved
Hide resolved
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/jws/JwsService.kt
Outdated
Show resolved
Hide resolved
JesusMcCloud
force-pushed
the
preview/integratedCrypto
branch
from
54c855e to
3c5ba7b
Compare
|
someone should really test this in the app. Just be sure, to also set the key agreement flag for EC key generation and delete the old holder key! |
|
then we just have to wait for @iaik-jheher to find the time to review the signum PR |
JesusMcCloud
force-pushed
the
preview/integratedCrypto
branch
from
3c5ba7b to
8f03c0e
Compare
|
Badum-Tsss! |
|
I did not yet get to testing it in the app, because first, we'll need snapshot releases of all credentials due to breaking changes in signum and I cannot make any guarantees to get to it before easter, but I will try to at least release the credentials with some distinctive version string as snapshots so testing becomes possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not much left of the cryptoservice. We could use this state to test encryption and key agreement on iOS, even before publishing signum. Maybe we should, because this way we could still catch any mishaps in signum before we merge there.
Opinions, anyone? @md4096?