Function parameters in methods #331
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
396
to
409
| private class BackupCredentialIssuerDataProvider() : CredentialIssuerDataProvider { | ||
| override fun getCredential( | ||
| userInfo: OidcUserInfoExtended, | ||
| subjectPublicKey: CryptoPublicKey, | ||
| credentialScheme: CredentialScheme, | ||
| representation: ConstantIndex.CredentialRepresentation, | ||
| claimNames: Collection<String>?, | ||
| ): KmmResult<CredentialToBeIssued> = catching { | ||
| TODO() | ||
| } | ||
|
|
There was a problem hiding this comment.
Explained the reasoning why this doesn't matter
nodh
force-pushed
the
feature/function-parameters-in-methods
branch
from
7fcc2ba to
d0b0f97
Compare
nodh
force-pushed
the
feature/credential-issuer-functions
branch
from
bef46b0 to
4be5967
Compare
nodh
force-pushed
the
feature/function-parameters-in-methods
branch
from
d0b0f97 to
fc8c9e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves parameters from the constructor of
CredentialIssuerinto the method we're they're actually used. Should allow for a more straight-forward integration into an issuing service.