Skip to content

Conversation

@Kratemis
Copy link

No description provided.

@Kratemis Kratemis mentioned this pull request Sep 12, 2025
@a1ex4
Copy link
Owner

a1ex4 commented Sep 12, 2025

Can you change the target branch to develop please?

For the shop name feature, I also wanted to add the shop name:

  • on top of the login form in the login page
  • in all messages displayed in Tinfoil (basically in tinfoil_error function and motd message)

Also can you avoid rendering the page based on the jinja variables, and use the settings available in js instead? I am trying to move away as much as possible on the jinja variables for rendering, if the settings are anyway available in js.

Thanks a lot for your contributions!

@Kratemis Kratemis changed the base branch from master to develop September 12, 2025 11:06
@Kratemis
Copy link
Author

Fixed!! =)

@a1ex4 a1ex4 added the type/feat PR adding a new feature label Sep 13, 2025
@a1ex4
Copy link
Owner

a1ex4 commented Sep 23, 2025

It's looking good but can you please change a few things:

  • translate spanish comments to english.
  • remove "shop info" get api call to use Jinja rendering. I know I said otherwise in another PR but for the shop name I prefer to render it directly in Jinja as it is non dynamic.
  • remove the "powered by" entirely, I don't want to add to many settings and I like the fact that people can name their shop as they want.
  • add a line return after the shop name in Tinfoi success/error messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feat PR adding a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants