feat: Added owned/missing badge #237
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Owner
|
I think there is a bug somewhere, I would not expect a DLC to be up to date yet missing. DLC files do not have separate "base" and "update" files, they have their own |
Contributor
|
DLC's don't get an "owned" flag in library generation, causing them to show "not owned" on the card, even if you have the file on disk. Separately, if a dlc only has v0, it falsely marks them as "up to date" if you don't own any versions. It's a small fix, I'll raise a PR for it. |
Contributor
|
Fixed in #254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added one more badge to the grid because I didn't understand why a lot of games appears in the grid. I realized that some algorithms write in db all the games related to the owned game... and the badge changes color but I think is better with a new badge...
Perhaps you don't like this change. I will understand hahahaha