Add new memoization guide #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows up the artifact guide with an example of a memo. This is work in progress until the cache and eviction policy are implemented and confirmed to work.
nicholasjng
force-pushed
the
update-artifact-guide
branch
from
ba08169
to
41d665b
Compare
maxmynter
approved these changes
Mar 26, 2024
| To address this problem, this guide introduces **memos** as a way to reduce memory pressure when benchmarking multiple memory-intensive models and datasets sequentially. | ||
|
|
||
| ## Using the `nnbench.Memo` class | ||
| // TODO: Move the class up into the main export. |
There was a problem hiding this comment.
Taking care of this in #130
| return np.sum(model.apply(data)) | ||
| ``` | ||
|
|
||
| //TODO: Add tearDown task clearing the memo cache. |
There was a problem hiding this comment.
Can also take care of this in #130
|
I'm going to address the TODOs after #130 is done, and proceed with this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up the artifact guide with an example of a memo. This is work in progress until the cache and eviction policy are implemented and confirmed to work.