Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe setting of CPU Info #146

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Safe setting of CPU Info #146

merged 5 commits into from
Jul 19, 2024

Commits on Jul 18, 2024

  1. Safe setting of CPU Info

    as the context information might not be available on all
    devices, e.g. in our GitHub CI VM the CPU frequency.
    
    Wrap setting of dict entry in a try, except blog that throws warn-
    ings when a value cannot be obtained.
    maxmynter committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ce249b0 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Revert "Safe setting of CPU Info"

    We decided on a more tailored approach and will only wrap the
    effected parts of the CPU info, not all of them.
    maxmynter committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    f7c9e3c View commit details
    Browse the repository at this point in the history
  2. Wrap cpu_freq() into try-except

    as the function is not available on all devices, e.g. apple ARM in
    our GitHub CI. In that case, set frequency avg, min, max to zero.
    maxmynter committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    64455d8 View commit details
    Browse the repository at this point in the history
  3. Update Test Condition for CPU Freq

    as we set the CPU frequency to zero when it is not available on the
    host machine. That is the case in the GitHub CI. We don't want this
    test to fail when there is the frequency 0 as then the CPUInfo has
    been correctly populated.
    maxmynter committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    34735b7 View commit details
    Browse the repository at this point in the history
  4. Replace bare Exception catch with RuntimeError catch

    as this is what is thrown by PSUTIL if the information is not
    available in the current machine.
    maxmynter committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b411e8b View commit details
    Browse the repository at this point in the history