Added hooks to templates for relationships.#1348
Open
mmitten wants to merge 1 commit intoaarondl:masterfrom
Open
Added hooks to templates for relationships.#1348mmitten wants to merge 1 commit intoaarondl:masterfrom
mmitten wants to merge 1 commit intoaarondl:masterfrom
Conversation
Collaborator
|
While I see this as a good change, I wonder if this may cause issues for those who are used to the current behaviour 🤔 |
Author
|
Now that you mention it, it could be a breaking change, as adding another hook trigger where it was previously not expected could lead to some unpleasant side effects. I am not opposed to tabling this for a major version revision, as the use case I wrote it for has since been resolved with something else. |
Collaborator
|
I'll label this as breaking and may add it to an eventual |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt to resolve #445
Added into the templates for relationships as I did not see any other place that made sense for how the hooks otherwise behaved. Happy to follow up if a something was missed.