Spec complete for sending and receiving messages

ably-labs · Oct 8, 2024 · 368a91c · 368a91c
2 parents 5f6c651 + 4da8e42
commit 368a91c
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 18 deletions.
diff --git a/Example/AblyChatExample/ContentView.swift b/Example/AblyChatExample/ContentView.swift
@@ -126,7 +126,7 @@ struct ContentView: View {
     func showMessages() async throws {
         for await message in try await room().messages.subscribe(bufferingPolicy: .unbounded) {
             withAnimation {
-                messages.insert(BasicListItem(id: message.timeserial, title: message.clientID ?? "Anonymous", text: message.text), at: 0)
+                messages.insert(BasicListItem(id: message.timeserial, title: message.clientID, text: message.text), at: 0)
             }
         }
     }

diff --git a/Sources/AblyChat/DefaultMessages.swift b/Sources/AblyChat/DefaultMessages.swift
@@ -9,7 +9,7 @@ private struct MessageSubscriptionWrapper {
     var timeserial: TimeserialString
 }
 
-public final class DefaultMessages: Messages, HandlesDiscontinuity {
+public final class DefaultMessages: Messages, EmitsDiscontinuities {
     private let roomID: String
     public let channel: RealtimeChannelProtocol
     private let chatAPI: ChatAPI

diff --git a/Sources/AblyChat/EmitsDiscontinuities.swift b/Sources/AblyChat/EmitsDiscontinuities.swift
@@ -3,18 +3,3 @@ import Ably
 public protocol EmitsDiscontinuities {
     func subscribeToDiscontinuities() async -> Subscription<ARTErrorInfo>
 }
-
-/**
- * Represents an object that has a channel and therefore may care about discontinuities.
- */
-@MainActor
-internal protocol HandlesDiscontinuity {
-    var channel: RealtimeChannelProtocol { get }
-
-//    var channel: RealtimeChannelProtocol? { get }
-    /**
-     * Called when a discontinuity is detected on the channel.
-     * @param reason The error that caused the discontinuity.
-     */
-    func discontinuityDetected(reason: ARTErrorInfo?)
-}
diff --git a/Sources/AblyChat/Rooms.swift b/Sources/AblyChat/Rooms.swift
@@ -27,7 +27,7 @@ internal actor DefaultRooms: Rooms {
         self.realtime = realtime
         self.clientOptions = clientOptions
         self.logger = logger
-        self.chatAPI = ChatAPI(realtime: realtime)
+        chatAPI = ChatAPI(realtime: realtime)
     }
 
     internal func get(roomID: String, options: RoomOptions) throws -> any Room {