-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Switch to (temporarily) use
main
branch of ably-cocoa
This allows us to make use of the Swift concurrency enhancements that have been added on `main`, and to identify any further concurrency enhancements that still need to be made (in response to any new concurrency errors that we get as we continue to develop the Chat SDK).
- Loading branch information
1 parent
620df5a
commit 7b3c97f
Showing
8 changed files
with
28 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,7 @@ | ||
import Ably | ||
|
||
// TODO: remove "@unchecked Sendable" once https://github.com/ably/ably-cocoa/issues/1962 done | ||
extension ARTRealtime: RealtimeClientProtocol {} | ||
|
||
// This @retroactive is needed to silence the Swift 6 compiler error "extension declares a conformance of imported type 'ARTRealtimeChannels' to imported protocol 'Sendable'; this will not behave correctly if the owners of 'Ably' introduce this conformance in the future (…) add '@retroactive' to silence this warning". I don’t fully understand the implications of this but don’t really mind since both libraries are in our control. | ||
extension ARTRealtime: RealtimeClientProtocol, @retroactive @unchecked Sendable {} | ||
extension ARTRealtimeChannels: RealtimeChannelsProtocol {} | ||
|
||
extension ARTRealtimeChannels: RealtimeChannelsProtocol, @retroactive @unchecked Sendable {} | ||
|
||
extension ARTRealtimeChannel: RealtimeChannelProtocol, @retroactive @unchecked Sendable {} | ||
extension ARTRealtimeChannel: RealtimeChannelProtocol {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters