Fix decoding of Message.createdAt

Noticed this when writing an integration test for getPreviousMessages.
ably-labs · Nov 7, 2024 · 9454e40 · 9454e40
1 parent fee9204
commit 9454e40
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/Sources/AblyChat/ChatAPI.swift b/Sources/AblyChat/ChatAPI.swift
@@ -127,7 +127,14 @@ internal final class ChatAPI: Sendable {
 }
 
 internal struct DictionaryDecoder {
-    private let decoder = JSONDecoder()
+    private let decoder = {
+        var decoder = JSONDecoder()
+
+        // Ably’s REST APIs always serialise dates as milliseconds since Unix epoch
+        decoder.dateDecodingStrategy = .millisecondsSince1970
+
+        return decoder
+    }()
 
     // Function to decode from a dictionary
     internal func decode<T: Decodable>(_: T.Type, from dictionary: NSDictionary) throws -> T {

diff --git a/Tests/AblyChatTests/ChatAPITests.swift b/Tests/AblyChatTests/ChatAPITests.swift
@@ -170,7 +170,7 @@ struct ChatAPITests {
                     clientID: "random",
                     roomID: roomId,
                     text: "hello",
-                    createdAt: nil,
+                    createdAt: .init(timeIntervalSince1970: 1_730_943_049.269),
                     metadata: [:],
                     headers: [:]
                 ),

diff --git a/Tests/AblyChatTests/Mocks/MockHTTPPaginatedResponse.swift b/Tests/AblyChatTests/Mocks/MockHTTPPaginatedResponse.swift
@@ -99,6 +99,7 @@ extension MockHTTPPaginatedResponse {
             [
                 "clientId": "random",
                 "timeserial": "3446456",
+                "createdAt": 1_730_943_049_269,
                 "roomId": "basketball::$chat::$chatMessages",
                 "text": "hello",
                 "metadata": [:],