[ECO-5104] Removes reserved keyspaces in line with CHADR-066

[umair-ably]

Removes reserved keyspaces in line with CHADR-066
https://ably.atlassian.net/wiki/spaces/CHA/pages/3438116905/CHADR-066+Removing+Reserved+Keyspace

Summary by CodeRabbit

• New Features

  • Simplified message sending process by removing specific error checks related to metadata and headers.

• Bug Fixes

  • Enhanced flexibility in sending messages without triggering errors for certain metadata and header configurations.

• Tests

  • Removed outdated tests that were checking for errors related to the now-removed validation checks.

[coderabbitai]

Walkthrough

The changes in this pull request involve significant modifications to the ChatAPI class, specifically the sendMessage method, by removing checks for specific keys in the metadata and headers parameters. This alteration simplifies the control flow and error handling, allowing the inclusion of previously restricted metadata and headers without triggering errors. Correspondingly, three related tests in ChatAPITests have been removed to align with the updated functionality.

Changes

File	Change Summary
Sources/AblyChat/ChatAPI.swift	Removed checks in sendMessage for "ably-chat" key in metadata and headers, altering error handling.
Tests/AblyChatTests/ChatAPITests.swift	Removed three tests related to the previous error checks in sendMessage.

Assessment against linked issues

Objective	Addressed	Explanation
Remove reserved keyspace for Messages (ECO-5104)	✅

Possibly related PRs

• Fix decoding of Message.createdAt #99: The changes in the sendMessage method of the ChatAPI class in the main PR directly relate to the modifications in the same method in PR Fix decoding of Message.createdAt #99, which introduced additional checks for metadata and headers.

Suggested reviewers

• maratal

Poem

In the chat where bunnies dwell,
We’ve waved goodbye to error's spell.
With keys unbound, our messages flow,
Hopping freely, to and fro! 🐇✨
Let’s chat away, with joy and cheer,
No more errors, just laughter here!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5e4a862 and f7f19cc.

📒 Files selected for processing (2)

• Sources/AblyChat/ChatAPI.swift (0 hunks)
• Tests/AblyChatTests/ChatAPITests.swift (0 hunks)

💤 Files with no reviewable changes (2)

• Sources/AblyChat/ChatAPI.swift
• Tests/AblyChatTests/ChatAPITests.swift

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.