Skip to content

connection: add missing closed/closing values to enum #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

connection: add missing closed/closing values to enum #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions chat/api/android/chat.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ public final class com/ably/chat/ConnectionKt {
}

public final class com/ably/chat/ConnectionStatus : java/lang/Enum {
public static final field Closed Lcom/ably/chat/ConnectionStatus;
public static final field Closing Lcom/ably/chat/ConnectionStatus;
public static final field Connected Lcom/ably/chat/ConnectionStatus;
public static final field Connecting Lcom/ably/chat/ConnectionStatus;
public static final field Disconnected Lcom/ably/chat/ConnectionStatus;
Expand Down
2 changes: 2 additions & 0 deletions chat/api/jvm/chat.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ public final class com/ably/chat/ConnectionKt {
}

public final class com/ably/chat/ConnectionStatus : java/lang/Enum {
public static final field Closed Lcom/ably/chat/ConnectionStatus;
public static final field Closing Lcom/ably/chat/ConnectionStatus;
public static final field Connected Lcom/ably/chat/ConnectionStatus;
public static final field Connecting Lcom/ably/chat/ConnectionStatus;
public static final field Disconnected Lcom/ably/chat/ConnectionStatus;
Expand Down
18 changes: 16 additions & 2 deletions chat/src/commonMain/kotlin/com/ably/chat/Connection.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,20 @@ public enum class ConnectionStatus(public val stateName: String) {
* (CHA-CS1f) The library is currently disconnected from Ably and will not attempt to reconnect.
*/
Failed("failed"),

/**
* (CHA-CS1g) An explicit request by the developer to close the connection has been sent
* to the Ably service. If a reply is not received from Ably within a short period of
* time, the connection is forcibly terminated and the connection status becomes Closed.
*/
Closing("closing"),

/**
* (CHA-CS1h) The connection has been explicitly closed by the client. In the closed state,
* no reconnection attempts are made automatically. No connection state is preserved by
* the service or the library.
*/
Closed("closed"),
}

/**
Expand Down Expand Up @@ -187,7 +201,7 @@ private fun mapPubSubStatusToChat(status: ConnectionState): ConnectionStatus {
ConnectionState.disconnected -> ConnectionStatus.Disconnected
ConnectionState.suspended -> ConnectionStatus.Suspended
ConnectionState.failed -> ConnectionStatus.Failed
ConnectionState.closing -> ConnectionStatus.Failed
ConnectionState.closed -> ConnectionStatus.Failed
ConnectionState.closing -> ConnectionStatus.Closing
ConnectionState.closed -> ConnectionStatus.Closed
}
}
Loading