-
Notifications
You must be signed in to change notification settings - Fork 0
Release v1.1.0 #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.1.0 #185
Conversation
WalkthroughAdds a 1.1.0 release: bumps project and dependency versions, updates README and CHANGELOG, and introduces two new ConnectionStatus enum members: Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as Application code
participant Status as ConnectionStatus (enum)
participant Logic as State handling (when/switch)
Note over Status,Logic: New enum values added: closing, closed
Caller->>Logic: query current ConnectionStatus
Logic->>Status: read value (e.g., closing)
alt handled explicitly
Logic->>Caller: handle closing/closed branch
else not updated
Logic->>Caller: fallthrough or default (previously treated as failed)
end
Note right of Logic: Update when/switch to be exhaustive for closing/closed
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
CHANGELOG.md(1 hunks)README.md(1 hunks)gradle.properties(1 hunks)gradle/libs.versions.toml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-02-14T13:26:06.027Z
Learnt from: sacOO7
PR: ably/ably-chat-kotlin#100
File: chat-android/src/test/java/com/ably/chat/integration/MessagesIntegrationTest.kt:203-250
Timestamp: 2025-02-14T13:26:06.027Z
Learning: In the Ably Chat Kotlin SDK, all messages (including deleted ones) are preserved in history as immutable events/records. Message deletion is implemented as a soft delete operation that adds a deletion event rather than removing the message from history.
Applied to files:
CHANGELOG.mdREADME.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: build
- GitHub Check: coverage
- GitHub Check: check
- GitHub Check: test (Android Debug tests, testDebugUnitTest)
- GitHub Check: test (Android Release tests, testReleaseUnitTest)
- GitHub Check: test (JVM tests, jvmTest)
🔇 Additional comments (4)
README.md (1)
48-48: Installation examples correctly updated to v1.1.0.Version bumps in both Groovy and Kotlin Script installation blocks are consistent with gradle.properties and follow the established format.
Also applies to: 54-54
gradle.properties (1)
21-21: VERSION_NAME correctly bumped to 1.1.0 for Maven publishing.Version update is consistent across gradle.properties, README.md, and CHANGELOG.md. Publishing metadata unchanged.
CHANGELOG.md (1)
3-9: v1.1.0 release entry is well-documented.The changelog entry correctly documents the ConnectionStatus enum additions and references the originating PR #184. Version links and format are consistent with previous releases (1.0.0 section at line 11).
gradle/libs.versions.toml (1)
5-5: Verify whether ably 1.4.2 is required for these changes.The ConnectionStatus enum changes (adding
closingandclosedstates) are documented in the ably-chat-kotlin v1.1.0 changelog, while ably-java 1.4.2 addresses a separate issue: async requests failing after reconnection. These are distinct concerns, and no evidence shows 1.4.2 is required for the ConnectionStatus changes. Confirm whether this bump is needed for integration stability or other dependencies in this PR, or if 1.4.1 remains compatible.
Code Coverage
|
This branch contains the changes for release 1.1.0.
Summary by CodeRabbit
New Features
closingandclosedfor finer connection-state visibility.Documentation
Chores