Skip to content

[REA-1702] feat: web push#1775

Merged
owenpearson merged 7 commits intomainfrom
push-activation-v2
Jul 2, 2024
Merged

[REA-1702] feat: web push#1775
owenpearson merged 7 commits intomainfrom
push-activation-v2

Conversation

@owenpearson
Copy link
Member

  • adds a plugin which enables clients to be activated for receipt of push notifications.
  • adds support for w3c push transport to web clients.
  • adds push channel transport for testing push activation on all platforms.

@owenpearson owenpearson requested review from VeskeR and ttypic May 22, 2024 08:42
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features May 22, 2024 08:43 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report May 22, 2024 08:43 Inactive
@owenpearson owenpearson force-pushed the push-activation-v2 branch from df841d6 to 9175832 Compare May 22, 2024 08:49
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features May 22, 2024 08:49 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report May 22, 2024 08:49 Inactive
Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! very consistent to what we have in java and cocoa, added couple of small comments

@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 12, 2024 21:10 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/typedoc June 12, 2024 21:10 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report June 12, 2024 21:11 Inactive
@jamienewcomb jamienewcomb requested a review from ttypic June 13, 2024 09:03
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 13, 2024 20:58 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report June 13, 2024 20:58 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/typedoc June 13, 2024 20:58 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 13, 2024 21:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report June 13, 2024 21:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/typedoc June 13, 2024 21:02 Inactive
Copy link
Contributor

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a wall of comments but mostly they are structural suggestions.

Couple of things that I couldn't attach to code lines:

  1. Should we add new Push plugin to scripts/moduleReport.ts pluginNames list? I imagine we would need to update getBundleInfo in there, as currently it always imports from './build/modular/index.mjs'.
  2. Per RSH7 both RestChannel and RealtimeChannel should have push object. Why did we add push only to RestChannel here?

P.S. sorry for the amount of comments 😬 I wonder if we could've done it in separate PRs for web push integration branch.

@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 17, 2024 15:59 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 17, 2024 16:07 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report June 17, 2024 16:07 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/typedoc June 17, 2024 16:07 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 17, 2024 17:41 Inactive
Copy link
Contributor

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes!
Really like the new classes for states! Looks much better and is easier to read.

Added couple more comments (and had to unresolve two previous comments I think), but we're really close now

@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 20, 2024 13:40 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/typedoc June 20, 2024 13:41 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report June 20, 2024 13:41 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 24, 2024 10:38 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/typedoc June 24, 2024 10:38 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report June 24, 2024 10:38 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 24, 2024 13:42 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report June 24, 2024 13:43 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/typedoc June 24, 2024 13:43 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 24, 2024 13:44 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report June 24, 2024 13:44 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/typedoc June 24, 2024 13:45 Inactive
@owenpearson owenpearson requested a review from VeskeR June 24, 2024 14:19
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 25, 2024 08:36 Inactive
Copy link
Contributor

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants