logger: pass level to logHandlers when logging#1787
Merged
Conversation
github-actions
bot
temporarily deployed
to
staging/pull/1787/bundle-report
AndyTWF
force-pushed
the
log-level-in-handler
branch
from
5574079 to
407354b
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1787/bundle-report
owenpearson
requested changes
Jun 11, 2024
Member
owenpearson
left a comment
owenpearson
left a comment
There was a problem hiding this comment.
Looks good, just one nitpick:
github-actions
bot
temporarily deployed
to
staging/pull/1787/bundle-report
owenpearson
approved these changes
Jun 11, 2024
ttypic
reviewed
Jun 13, 2024
This allows handlers to make choices depending on the level of the log being raised (e.g. sending the logs to crashlytics when a certain number of error-level logs occur).
AndyTWF
force-pushed
the
log-level-in-handler
branch
from
543fe53 to
a43d920
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows handlers to make choices depending on the level of the log being raised (e.g. sending the logs to crashlytics when a certain number of error-level logs occur).
Other ecosystems that do already have this have the level before the message, however in this case we'll put the level second in order to ensure backwards compatibility.