-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Export ABP documentation as PDF #22430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do we delete expired PDFs? As far as I understand, they are not deleted. This will be costly over time.
My review is not finished. I will continue later.
...lication.Contracts/Volo/Docs/Common/Localization/Resources/Docs/ApplicationContracts/tr.json
Outdated
Show resolved
Hide resolved
…ocs/Common/Localization/Resources/Docs/ApplicationContracts/tr.json Co-authored-by: SALİH ÖZKARA <[email protected]>
Co-authored-by: SALİH ÖZKARA <[email protected]>
@@ -772,7 +781,9 @@ private async Task SetDocumentPreferencesAsync() | |||
return; | |||
} | |||
|
|||
var availableParameters = await _documentSectionRenderer.GetAvailableParametersAsync(Document.Content); | |||
var availableParameters = await _webDocumentSectionRenderer.GetAvailableParametersAsync(Document.Content); | |||
var parameterCombinations = new List<Dictionary<string, string>>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this variable used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently only markdown is supported, but we do this with abstraction. No direct markdown-specific code should be written here.
Description
Resolves #16792 https://github.com/volosoft/vs-internal/issues/6073
Checklist
How to test it?
Configure the docs module according to https://abp.io/docs/latest/modules/docs
Use the
VoloDocs.Web
project for testing.