Skip to content

Export ABP documentation as PDF #22430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Export ABP documentation as PDF #22430

wants to merge 12 commits into from

Conversation

realLiangshiwei
Copy link
Member

@realLiangshiwei realLiangshiwei commented Mar 24, 2025

Description

Resolves #16792 https://github.com/volosoft/vs-internal/issues/6073

image image image image

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Configure the docs module according to https://abp.io/docs/latest/modules/docs
Use the VoloDocs.Web project for testing.

@realLiangshiwei realLiangshiwei marked this pull request as draft March 24, 2025 10:10
@realLiangshiwei realLiangshiwei changed the title Export ABP documentation as PDF/Markdown Export ABP documentation as PDF Mar 24, 2025
@realLiangshiwei realLiangshiwei marked this pull request as ready for review April 22, 2025 08:42
@realLiangshiwei realLiangshiwei added this to the 9.3-preview milestone Apr 22, 2025
@oykuermann oykuermann requested review from yagmurcelk and removed request for oykuermann April 22, 2025 13:47
Copy link
Member

@salihozkara salihozkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we delete expired PDFs? As far as I understand, they are not deleted. This will be costly over time.

My review is not finished. I will continue later.

realLiangshiwei and others added 2 commits April 24, 2025 13:39
…ocs/Common/Localization/Resources/Docs/ApplicationContracts/tr.json

Co-authored-by: SALİH ÖZKARA <[email protected]>
@@ -772,7 +781,9 @@ private async Task SetDocumentPreferencesAsync()
return;
}

var availableParameters = await _documentSectionRenderer.GetAvailableParametersAsync(Document.Content);
var availableParameters = await _webDocumentSectionRenderer.GetAvailableParametersAsync(Document.Content);
var parameterCombinations = new List<Dictionary<string, string>>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this variable used for?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently only markdown is supported, but we do this with abstraction. No direct markdown-specific code should be written here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export ABP documentation as PDF/Markdown
2 participants