fix: Eventhub Website Findings. #151
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR addresses various website findings for EventHub, primarily updating ABP framework dependencies from version 9.3.4 to 9.3.7 and fixing minor UI issues including capitalization consistency, redundant DOM manipulation code, and duplicate styling elements.
- Updated all @abp packages from 9.3.4 to 9.3.7 across both Web and IdentityServer projects
- Fixed capitalization of "Event" to "event" in user-facing messages for consistency
- Removed redundant member name display code and styling manipulation
- Added toast message styling and removed duplicate tab header elements
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/EventHub.Web/yarn.lock | Updated @abp package versions from 9.3.4 to 9.3.7 with new registry URLs |
| src/EventHub.IdentityServer/yarn.lock | Updated @abp package versions from 9.3.4 to 9.3.7 with new registry URLs |
| src/EventHub.Web/Pages/Organizations/Profile.cshtml | Fixed capitalization: "Event" → "event" |
| src/EventHub.Web/Pages/Events/Components/EventsArea/Default.cshtml | Fixed capitalization: "Event" → "event" |
| src/EventHub.Web/Pages/Organizations/Components/MembersArea/members-area.js | Removed redundant style attribute removal |
| src/EventHub.Web/Pages/Organizations/Components/MembersArea/_memberListSection.cshtml | Removed unused member-name span element |
| src/EventHub.Web.Theme/wwwroot/themes/eventhub/style.css | Added white color styling for toast messages |
| src/EventHub.IdentityServer/Pages/Account/Manage.cshtml | Removed duplicate tab header and horizontal rule |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.