-
Notifications
You must be signed in to change notification settings - Fork 188
Media mgr updates and context class #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JamesHabben
commented
Jun 23, 2025
- create context class to hold more info about current module and artifact
- update media functions to use info from context class to reduce params required from modules
- see commit notes for more details
- zero matches for test cases in test data so far
- create `Context` class - update `artifact_processor` to hydrate context info - update `artifact_processor` to determine old vs context func sig - update `check_in_media` and `check_in_embedded_media` functions to use context instead of params - remove now excess parameters from `check_in_media` - update `test_module` to mock additional functions and context data - update `test_module` to determine old vs context func sig
- fix file path
update to new media function
- update to use new media functions - create test case data - create test case results
- update module to use new media function signatures - update module to include cache files in file pattern search - update module to not use seeker to find additional files - create test case data - create result data - update test module to better mock media item info
- update media check in function - adjust file search path - update columns to include lava render types
- update to use new media check in function - update test case data - update test results
- update to use new media check in function - create test data - create test results - NOTE: responsive files, but no responsive records in db
- update to use new media function - create test case data - create test results data
- update to use new media check in - create test case data - create test results
- update to use new media function - create test case data - create test results - update a missed line in address book. oops.
update to context param
update to using context param
here is a rundown of what's going on:
thats a summary of the changes in |
- update to context param - update to new media function - update to use media column type
Everything is OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.