Skip to content

Conversation

@ctdunc
Copy link
Collaborator

@ctdunc ctdunc commented Sep 2, 2025

think this change will allow all wheels to be published

@abstractqqq
Copy link
Owner

think this change will allow all wheels to be published

I think something is wrong in the release workflow when downloading artifacts:

In polars_istr, we have name: wheels

 release:
    name: Release
    runs-on: ubuntu-latest
    if: "startsWith(github.ref, 'refs/tags/')"
    needs: [linux, windows, macos, sdist]
    permissions:
      id-token: write
    environment: release
    steps:
      - uses: actions/download-artifact@v4
        with:
          name: wheels
      - name: Publish to PyPI
        uses: PyO3/maturin-action@v1
        with:
          command: upload
          args: --non-interactive --skip-existing *

But in polars_ds, I am using a pattern here pattern: wheel-*

  release:
    name: Release
    runs-on: ubuntu-latest
    if: "startsWith(github.ref, 'refs/tags/')"
    needs: [build-wheels, create-sdist]
    permissions:
        id-token: write
    steps:
      - uses: actions/download-artifact@v4
        with:
          pattern: wheel-*
          merge-multiple: true

      - uses: actions/download-artifact@v4
        with:
          pattern: sdist-*
          merge-multiple: true
          
      - name: Publish to PyPI
        uses: PyO3/maturin-action@v1
        with:
          command: upload
          args: --non-interactive --skip-existing *

@ctdunc ctdunc force-pushed the chore/upload-more-wheels branch from 5dc45b4 to 62c4622 Compare September 2, 2025 23:53
@abstractqqq abstractqqq merged commit ccf6534 into abstractqqq:main Sep 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants