Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple bugs that cropped up on the Jenkins restart #270

Merged
merged 3 commits into from
Jan 28, 2024

Conversation

tgrogers
Copy link
Contributor

Fixing a file naming error that was affecting the PTX job status and stat collection readings.
Also changed the monitor script initiation to actually fail if there are errors with the small tests.

@tgrogers tgrogers requested a review from FJShen January 28, 2024 15:13
@FJShen
Copy link
Contributor

FJShen commented Jan 28, 2024

A couple of Jenkins issues still persist and look quite serious ⚠.

  1. We still have problems with path names. Go to this link https://tgrogers-pc01.ecn.purdue.edu/job/accel-sim-tracer/job/accel-sim-framework/view/change-requests/job/PR-270/1/consoleText - it is the raw text log of this CI test - and search for the string /racer_accel-sim-.
  2. The link for the status of the CI test from this Github pull request page to our Jenkins server is not working (if you click on the "details" button after the "continuous-integration/jenkins/pr-merge — This commit looks good" item)
  3. Related to the previous point: strangely, I found the CI test status for this PR at this URL: https://tgrogers-pc01.ecn.purdue.edu/job/accel-sim-tracer/job/accel-sim-framework/view/change-requests/job/PR-270/ Note that this PR is under the path of "Dashboard > accel-sim-tracer > accel-sim-framework > Pull Requests (11) > PR-270" on our Jenkins server webpage.
  4. According to the log of the Jenkins CI test for this PR, PTX was not tested. I reached this conclusion by searching for "QV100-PTX" and not finding a hit in the raw log file.

Copy link
Contributor

@FJShen FJShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments above

@tgrogers
Copy link
Contributor Author

@FJShen - thanks for the quick look and engaged reply.
Let's handle these things this way:

  1. Please approve if everything is fine with this fix (i.e., it is pure goodness, not all the goodness we want, but goodness nonetheless).
  2. Take each line item of stuff that is broken, create an issue, and assign it to me.

We should aim at making continuous progress in small increments, rather than forcing giant PRs that fix the world.

@FJShen
Copy link
Contributor

FJShen commented Jan 28, 2024

Looks like pure goodness after all.

@FJShen FJShen merged commit a1ca547 into accel-sim:dev Jan 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants