-
-
Notifications
You must be signed in to change notification settings - Fork 141
WIP : @accounts/token-manager Adds a package to manage jwt's #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
+ Coverage 93.19% 93.35% +0.15%
==========================================
Files 44 46 +2
Lines 1191 1219 +28
Branches 162 174 +12
==========================================
+ Hits 1110 1138 +28
Misses 70 70
Partials 11 11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
||
private refreshTokenConfig: TokenGenerationConfiguration; | ||
|
||
constructor(config: Configuration) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are your thoughts on just defining and exporting Configuration
interface within this file and eliminating ./types
entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to enforce a pattern which has to be respected by all the packages of the suite, so if a potential contributor need to add a package, he will apply the pattern to his package naturally
I agree It is not needed everywhere but seeing that we at accounts-JS do apply it everywhere, the potential contributor will tend to adopt the pattern
Also, I like when the only different thing between two things is what actually make them different
Closed in favor of #222 |
This package has the purpose to be used by the AccountsServer class to manage JWT's in a cleaner way
Usage:
By now it is not implemented anywhere, but the goal is to pass it to accountsServer this way :