Skip to content

feat(spire): use join_token to authenticate and push data to SaaS #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(spire): use join_token to authenticate and push data to SaaS #55

wants to merge 2 commits into from

Conversation

vishnusomank
Copy link

@vishnusomank vishnusomank commented Jan 27, 2025 •
edited by jira bot
Loading

This PR contains the following changes:

  • spire related changes like spire-server url, join_token, configmap, secret and roles
  • updated jobs and cronjobs environment variables and container commands

Relates to: CNAPP-17132

DO-NOT-MERGE: This requires changes to the current accuknox-job container which is WIP

daemon1024
daemon1024 approved these changes Feb 17, 2025
View reviewed changes
Copy link

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnusomank
fix url
1772570 
Signed-off-by: Vishnu Soman <[email protected]>
seswarrajan
seswarrajan approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@seswarrajan seswarrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seswarrajan
Copy link
Contributor

Can you resolve these conflicts please.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daemon1024 daemon1024 daemon1024 approved these changes

@seswarrajan seswarrajan seswarrajan approved these changes

@raviknox raviknox Awaiting requested review from raviknox

@sanjay-ba sanjay-ba Awaiting requested review from sanjay-ba

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vishnusomank @seswarrajan @daemon1024