Skip to content

[new_profile - multilingual] Fixes translation of "OK" in swal message.#10066

Merged
driusan merged 3 commits intoaces:mainfrom
racostas:2025_10_27_new_profile_fixes_translates_OK_in_swal_message
Oct 29, 2025
Merged

[new_profile - multilingual] Fixes translation of "OK" in swal message.#10066
driusan merged 3 commits intoaces:mainfrom
racostas:2025_10_27_new_profile_fixes_translates_OK_in_swal_message

Conversation

@racostas
Copy link
Contributor

Brief summary of changes

  • Fixes issue detected in [new_profile] Translate module new_profile to Hindi #9900 where the "OK" in the SWAL messages were not been translated.
  • Spanish language was use for demonstration purposes only. ( Also the only Spanish translations included in the loris.po file were the ones used in this module -- for simplicity and speeding the process)

Testing instructions (if applicable)

  1. Go to new_profile module and try to create a candidate putting date of births that mismatch. (in a language other than english)
  2. The button OK in the error message should appear translated now.
image

@racostas racostas requested review from SKADE2303 and driusan October 27, 2025 20:28
@github-actions github-actions bot added Language: Javascript PR or issue that update Javascript code Module: new_profile PR or issue related to new_profile module labels Oct 27, 2025
@racostas racostas added Multilingual Any tasks related to making LORIS multilingual and removed Language: Javascript PR or issue that update Javascript code Module: new_profile PR or issue related to new_profile module labels Oct 27, 2025
@github-actions github-actions bot added Language: Javascript PR or issue that update Javascript code Module: new_profile PR or issue related to new_profile module labels Oct 27, 2025
msgstr "Ocultar filtros avanzados"

# Common swal labels
msgid "OK"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's just one new string can you add "わかりました" to the Japanese translation? (Not 100% sure if we should use "わかりました" or "はい" but as the default for swal but Google translate goes with the former to translate "OK" so let's just use that for now.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done !

Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works for me.

@driusan driusan merged commit 1d4cb9b into aces:main Oct 29, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: Javascript PR or issue that update Javascript code Module: new_profile PR or issue related to new_profile module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants