Skip to content

Conversation

@marandmart
Copy link
Contributor

Brief summary of changes

Updated and Reordered Icons on Recent Queries Panel

  • Updated execute query and share query with more standardly used icons

Previously

image

Updated

Screenshot 2025-11-26 at 7 40 23 AM

Link(s) to related issue(s)

558: https://github.com/aces/CBIGR/issues/558

@github-actions github-actions bot added the Module: dataquery PR or issue related to (new) dataquery module label Nov 26, 2025
@marandmart marandmart mentioned this pull request Nov 26, 2025
Copy link
Collaborator

@CamilleBeau CamilleBeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing happens when clicking the "Share" button

@CamilleBeau CamilleBeau added the State: Needs work PR awaiting additional work by the author to proceed label Jan 6, 2026
@charliehenrib
Copy link
Contributor

I see that the query move at the top and said it shared, but I think it would be good to keep the visual color. @marandmart had you removed the color on purpose?
image

@marandmart
Copy link
Contributor Author

@CamilleBeau
I added colour changing behaviour back to the icon

@charliehenrib
My bad, I missed that behaviour when swapping the icons. It was still supposed to change colour after being clicked. I added it back

@CamilleBeau CamilleBeau removed the State: Needs work PR awaiting additional work by the author to proceed label Jan 8, 2026
Copy link
Collaborator

@CamilleBeau CamilleBeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@charliehenrib
Copy link
Contributor

@marandmart I think you aded the feature where shared query are appearing above. Would it be possible to add a validation where to share a query, it has to be named?
Currently, you can share any queries but only the named one appear above, which leads to confusing as to whether the unnamed queries are even shared.

@charliehenrib charliehenrib added the State: Needs work PR awaiting additional work by the author to proceed label Jan 8, 2026
@marandmart
Copy link
Contributor Author

@marandmart I think you aded the feature where shared query are appearing above. Would it be possible to add a validation where to share a query, it has to be named? Currently, you can share any queries but only the named one appear above, which leads to confusing as to whether the unnamed queries are even shared.

Hi Charlie! In this PR I only swapped the icons, I didn't make any changes to how things work. I can make that change you suggested in a separate PR, it doesn't seem like it would take a lot of time!

@charliehenrib
Copy link
Contributor

@marandmart I think you aded the feature where shared query are appearing above. Would it be possible to add a validation where to share a query, it has to be named? Currently, you can share any queries but only the named one appear above, which leads to confusing as to whether the unnamed queries are even shared.

Hi Charlie! In this PR I only swapped the icons, I didn't make any changes to how things work. I can make that change you suggested in a separate PR, it doesn't seem like it would take a lot of time!

I think making these changes in a new PR is a good idea. Thank you. This PR is good to go then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module: dataquery PR or issue related to (new) dataquery module State: Needs work PR awaiting additional work by the author to proceed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants