-
Notifications
You must be signed in to change notification settings - Fork 191
Dqt improvements recent queries icons #10160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Dqt improvements recent queries icons #10160
Conversation
CamilleBeau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing happens when clicking the "Share" button
|
I see that the query move at the top and said it shared, but I think it would be good to keep the visual color. @marandmart had you removed the color on purpose? |
|
@CamilleBeau @charliehenrib |
CamilleBeau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
@marandmart I think you aded the feature where shared query are appearing above. Would it be possible to add a validation where to share a query, it has to be named? |
Hi Charlie! In this PR I only swapped the icons, I didn't make any changes to how things work. I can make that change you suggested in a separate PR, it doesn't seem like it would take a lot of time! |
I think making these changes in a new PR is a good idea. Thank you. This PR is good to go then. |

Brief summary of changes
Updated and Reordered Icons on Recent Queries Panel
Previously
Updated
Link(s) to related issue(s)
558: https://github.com/aces/CBIGR/issues/558