Skip to content

Comments

Fix: PSCID type for random generation in API projects endpoint (#9551)#10258

Merged
driusan merged 1 commit intoaces:mainfrom
arnav-makkar:fix/9551-pscid-type-random
Feb 9, 2026
Merged

Fix: PSCID type for random generation in API projects endpoint (#9551)#10258
driusan merged 1 commit intoaces:mainfrom
arnav-makkar:fix/9551-pscid-type-random

Conversation

@arnav-makkar
Copy link
Contributor

Brief summary of changes

Updated the projects/ API endpoint to correctly report the PSCID:Type as auto when the generation method is set to random. Previously, the logic only considered sequential as auto, which caused random (another automatic generation method) to be incorrectly described as prompt.

Link(s) to related issue(s)

@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Module: api PR or issue related to api module labels Jan 10, 2026
@CamilleBeau CamilleBeau requested a review from racostas January 19, 2026 20:25
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense and effectively includes "random" as an "auto-generated" method.

Looks good to me.

I leave the final code review approval to you @driusan please.

Thanks.

@racostas racostas added the Passed manual tests PR has been successfully tested by at least one peer label Feb 2, 2026
@driusan driusan merged commit ebcc5d9 into aces:main Feb 9, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: PHP PR or issue that update PHP code Module: api PR or issue related to api module Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API projects/ endpoint describes PSCID:type

3 participants