Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[candidate_parameters] Fix DB select with iterator_to_array #9733

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CamilleBeau
Copy link
Contributor

Brief summary of changes

This PR wraps the $db->pselect() call with iterator_to_array so that it can be processed with .map in DiagnosisEvolution.js. This is necessary following the change in #9334

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Open the candidate parameters module for any participant and go to the Diagnosis Evolution tab
  2. Make sure there are no errors

Link(s) to related issue(s)

@CamilleBeau CamilleBeau added the 27.0.0 - Bugs Bugs Found in LORIS 27 testing label Mar 26, 2025
@CamilleBeau CamilleBeau added this to the 27.0.0 milestone Mar 26, 2025
@CamilleBeau CamilleBeau added the Module: candidate_parameters PR or issue related to candidate_parameters module label Mar 26, 2025
@driusan
Copy link
Collaborator

driusan commented Mar 27, 2025

@CamilleBeau did you try this with a candidate that returns 0 rows to ensure it's encoded as [] and not {}?

@CamilleBeau
Copy link
Contributor Author

@CamilleBeau did you try this with a candidate that returns 0 rows to ensure it's encoded as [] and not {}?

Yes I tried with both a participant with and without data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Module: candidate_parameters PR or issue related to candidate_parameters module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[candidate_parameters] Error related to diagnosisEvolution
3 participants