[instruments] Make legacy dictionary use OPTIONAL as a default

[ridz1208]

Brief summary of changes

When declared as single the new DQT does not allow to choose the option "is empty" in the filter. since this trait is used for all legacy instruments, it seems safer to use optional than SINGLE.

Testing instructions (if applicable)

Link(s) to related issue(s)

• Resolves # (Reference the issue this fixes, if any.)

[skarya22]

@ridz1208 I am not quite sure how to test this .. Where is the _getDataDictionaryGroup function used? It doesn't say anywhere when I search it in the repo

[ridz1208]

@skarya22 ideally you go to the new DQT, if you try to add a filter for an instrument field, with my changes you will get the isEmpty option, without my changes there is only the base operators

[skarya22]

Works well for AOSI (PHP Instrument)
Before:

After:

But BMI Calculator still has no Empty options (LINST instrument)

Do we want to fix for LINST too or nah

[ridz1208]

@skarya22 can you clarify what needs clarification ?

what do you mean by fix for LINST? there should not be a difference between LINST and PHP in terms of dictionary

[skarya22]

@skarya22 can you clarify what needs clarification ?

what do you mean by fix for LINST? there should not be a difference between LINST and PHP in terms of dictionary

BMI Calculator still has no Empty options, if that is not intentional then I think the PR needs work for LINST to have the same options

[ridz1208]

@skarya22 Added the OPTIONAL for all cases I could think of that could potentially be "empty"

[ridz1208]

@kongtiaowang this PR keeps failing on "waiting for mysqld" and timing out but I just rebased it and it doesnt touch on any SQL code. is 26.0-release broken ?

[kongtiaowang]

After [github CI] waiting for mysqld - fix in 26.0-release #10118 get merged will fix the issue.

[driusan]

#10118 is merged

[ridz1208]

FIANLLY. Thanks @kongtiaowang