Skip to content

[login] Improve request account email #9802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

skarya22
Copy link
Contributor

Brief summary of changes

  • Update the request account email to have more useful information
    Before:
    image
    After:
    image

Testing instructions (if applicable)

  1. Disable sandbox and set your user to receive request account emails (Change Sandbox in project/config.xml to be 0, and in modules/login/php/signup.class.inc just change line 252 to be your email)
  2. Request an account and check your email

@skarya22 skarya22 added the Project: CCNA Issue or PR related to the CCNA project label May 22, 2025
@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Module: login PR or issue related to login module labels May 22, 2025
@driusan
Copy link
Collaborator

driusan commented May 22, 2025

I approve Persephone Arya's account but have no particular feelings about this pull request.

@skarya22
Copy link
Contributor Author

@driusan Main goal was to add the URL at the bottom + the site as the email did not include site before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language: PHP PR or issue that update PHP code Module: login PR or issue related to login module Project: CCNA Issue or PR related to the CCNA project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants