-
Notifications
You must be signed in to change notification settings - Fork 189
[wiki] fix README.md in 02_GETTING_STARTED #9817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wiki] fix README.md in 02_GETTING_STARTED #9817
Conversation
|
Thanks Saket! @SKADE2303 I think this resolves a different issue #9782 - just a quick update to your Description would clarify this. |
|
Hi @driusan, it seem our new GSoC student need some permissions for the automatic test to run. When you get back let's please grant this permissions to him. Thank you ! |
|
thanks @kongtiaowang ! |
|
@racostas I don't know what permissions you want him to have or why you think I can give them |
|
The PR also looks like the tests ran on it? |
|
Hi @driusan, yes thanks the permissions were already granted by Pierre, also for this on in particular @kongtiaowang give the approval for the test to run. Thanks !! |
racostas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
@driusan, since this PR fixed documentation, do you think could be going to the release branch instead of the main one ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SKADE2303 for this PR to main - approving.
@driusan over to you for final review and merge, thanks - this is from Saket our GSOC student.
@racostas valid point in your comment this this change could also go to the Release branch, in a separate PR - not sure it's essential to the release at this point in time but nice to have if Dave responds on that point.
7e0dbf0 to
155478f
Compare
|
Hi @driusan, I confirm @SKADE2303 properly rebased this PR. Cloud you please take a final look and merged into 27 or into a bug_fix if the case ? Thanks ! |
Brief summary of changes
Fixing typo in README.md inside 02_GETTING_STARTED in wiki
Testing instructions (if applicable)
Link(s) to related issue(s)