Skip to content

Conversation

@SKADE2303
Copy link
Collaborator

@SKADE2303 SKADE2303 commented May 27, 2025

Brief summary of changes

Fixing typo in README.md inside 02_GETTING_STARTED in wiki

Testing instructions (if applicable)

  1. Go to
  2. The typo in line 1 was changed from "it's" to "its" .

Link(s) to related issue(s)

@christinerogers
Copy link
Contributor

Thanks Saket! @SKADE2303

I think this resolves a different issue #9782 - just a quick update to your Description would clarify this.

@racostas racostas added Event: GSOC PR or issue accepted for Google Summer of Code may_tasks for special projects see CR or RA Category: Documentation PR or issue that aims to improve the documentation "Help! I don't understand Travis!" PR is having a beef with TRAVIS. Someone needs to help labels May 27, 2025
@racostas
Copy link
Contributor

Hi @driusan, it seem our new GSoC student need some permissions for the automatic test to run. When you get back let's please grant this permissions to him.

Thank you !

@kongtiaowang kongtiaowang removed the "Help! I don't understand Travis!" PR is having a beef with TRAVIS. Someone needs to help label Jun 3, 2025
@racostas
Copy link
Contributor

racostas commented Jun 3, 2025

thanks @kongtiaowang !

@driusan
Copy link
Collaborator

driusan commented Jun 3, 2025

@racostas I don't know what permissions you want him to have or why you think I can give them

@driusan
Copy link
Collaborator

driusan commented Jun 3, 2025

The PR also looks like the tests ran on it?

@racostas
Copy link
Contributor

racostas commented Jun 4, 2025

Hi @driusan, yes thanks the permissions were already granted by Pierre, also for this on in particular @kongtiaowang give the approval for the test to run. Thanks !!

Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@racostas
Copy link
Contributor

racostas commented Jun 9, 2025

@driusan, since this PR fixed documentation, do you think could be going to the release branch instead of the main one ?

@racostas racostas added the Passed manual tests PR has been successfully tested by at least one peer label Jun 9, 2025
Copy link
Contributor

@christinerogers christinerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SKADE2303 for this PR to main - approving.

@driusan over to you for final review and merge, thanks - this is from Saket our GSOC student.

@racostas valid point in your comment this this change could also go to the Release branch, in a separate PR - not sure it's essential to the release at this point in time but nice to have if Dave responds on that point.

@christinerogers christinerogers requested a review from driusan June 10, 2025 07:26
@SKADE2303 SKADE2303 changed the base branch from main to 27.0-release June 26, 2025 17:21
@SKADE2303 SKADE2303 force-pushed the 2025_05_27_wiki_fix_02_GETTING_STARTED_README branch from 7e0dbf0 to 155478f Compare June 26, 2025 17:33
@github-actions github-actions bot added Language: SQL PR or issue that update SQL code Language: PHP PR or issue that update PHP code Module: statistics PR or issue related to statistics module Module: issue_tracker PR or issue related to issue tracker module Module: dqt PR or issue related to (old) dqt module Module: acknowledgements PR or issue related to acknowledgements module Module: api PR or issue related to api module Module: api_docs PR or issue related to api_docs module labels Jun 26, 2025
@racostas racostas removed Module: genomic_browser PR or issue related to genomic_browser module Module: help_editor PR or issue related to help_editor module Module: imaging_browser PR or issue related to imaging_browser module Module: imaging_qc PR or issue related to imaging_qc module Module: imaging_uploader PR or issue related to imaging_uploader module Module: instrument_builder PR or issue related to instrument_builder module Module: instrument_list PR or issue related to instrument_list module Module: instrument_manager PR or issue related to instrument_manager module Module: instruments PR or issue related to instruments module Module: login PR or issue related to login module Module: media PR or issue related to media module Module: module_manager PR or issue related to module_manager module Module: mri_violations PR or issue related to mri_violations module Module: my_preferences PR or issue related to my_preferences module Module: new_profile PR or issue related to new_profile module Module: next_stage PR or issue related to next_stage module Module: oidc PR or issue related to the oidc (OpenID Connect) module Module: publication PR or issue related to the publication module Module: schedule_module PR or issue related to the schedule_manager module Module: server_processes_manager PR or issue related to the server_processes_manger Module: survey_accounts PR or issue related to the survey_accounts module Module: timepoint_list PR or issue related to the timepoint_list module Module: user_accounts PR or issue related to the user_accounts module Module: dicom_archive PR or issue related to dicom_archive module Module: data_release PR or issue related to data_release module Module: dataquery PR or issue related to (new) dataquery module labels Jun 26, 2025
@racostas
Copy link
Contributor

Hi @driusan, I confirm @SKADE2303 properly rebased this PR. Cloud you please take a final look and merged into 27 or into a bug_fix if the case ?

Thanks !

@racostas racostas added the Passed manual tests PR has been successfully tested by at least one peer label Jun 26, 2025
@driusan driusan merged commit a64b52a into aces:27.0-release Jun 27, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Documentation PR or issue that aims to improve the documentation Event: GSOC PR or issue accepted for Google Summer of Code may_tasks for special projects see CR or RA Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[may] fix typo in wiki Readme

5 participants