Skip to content

[new_profile] Translate module new_profile to Hindi#9900

Merged
driusan merged 9 commits intoaces:mainfrom
SKADE2303:translateNew_Profile
Oct 9, 2025
Merged

[new_profile] Translate module new_profile to Hindi#9900
driusan merged 9 commits intoaces:mainfrom
SKADE2303:translateNew_Profile

Conversation

@SKADE2303
Copy link
Contributor

@SKADE2303 SKADE2303 commented Jul 7, 2025

Brief summary of changes

This PR provides the infrastructure for the translation of the module new_profile to another language. The translation is done in a similar method as #9797 .

Testing instructions (if applicable)

  1. Make sure the languages table in Loris includes the language Hindi.
  2. Confirm that the Hindi language pack is installed on the server.
  3. Update the my_preference table to set the preferred language as Hindi.

Link(s) to related issue(s)

@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: statistics PR or issue related to statistics module Module: issue_tracker PR or issue related to issue tracker module Module: dqt PR or issue related to (old) dqt module Module: acknowledgements PR or issue related to acknowledgements module Module: api_docs PR or issue related to api_docs module Module: battery_manager PR or issue related to battery_manager module Module: behavioural_qc PR or issue related behavioural_qc module Module: brainbrowser PR or issue related to brainbrowser module Module: bvl_feedback PR or issue related to bvl_feedback module Module: candidate_list PR or issue related to candidate_list module Module: candidate_parameters PR or issue related to candidate_parameters module Module: candidate_profile PR or issue related to candidate_profile module Module: configuration PR or issue related to configuration module Module: conflict_resolver PR or issue related to conflict_resolver module Module: create_timepoint PR or issue related to create_timepoint module Module: dashboard PR or issue related to dashboard module Module: datadict PR or issue related to (old) datadict module Module: dictionary PR or issue related to (new) dictionary module Module: document_repository PR or issue related to documen_repository module Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Module: electrophysiology_uploader PR or issue related to electrophysiology_uploader Module: examiner PR or issue related to examiner module Module: genomic_browser PR or issue related to genomic_browser module Module: help_editor PR or issue related to help_editor module Module: imaging_browser PR or issue related to imaging_browser module Module: imaging_qc PR or issue related to imaging_qc module Module: imaging_uploader PR or issue related to imaging_uploader module Module: instrument_builder PR or issue related to instrument_builder module labels Jul 7, 2025
@racostas
Copy link
Contributor

racostas commented Sep 30, 2025

Is this one ready to be re-reviewed ?
Also the unrelated text failing are fixed already. Please relaunch the tests.

racostas
racostas requested changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many comment in the code from previous contributor are still been deleted by this PR. and I'm not sure the rational of this.

Please @SKADE2303 can you explain a bit more -- case by case preferably. Thanks !

modules/new_profile/jsx/NewProfileIndex.js
Comment on lines 152 to 153
}).then((result) => {
// Go to the candidate profile or reload the page, depending
// on whether the user clicked on 'Access Profile' or
// 'Recruit another candidate' respectively
window.location.href = result.value === true
Copy link
Contributor

@racostas racostas Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this and other comments from the original developer of the module not longer valid ?
Why we are deleting this ones ?

@kongtiaowang kongtiaowang reopened this Sep 30, 2025
@SKADE2303 SKADE2303 closed this Sep 30, 2025
@SKADE2303 SKADE2303 deleted the translateNew_Profile branch September 30, 2025 16:31
@SKADE2303 SKADE2303 restored the translateNew_Profile branch September 30, 2025 16:38
@SKADE2303 SKADE2303 reopened this Sep 30, 2025
@SKADE2303 SKADE2303 removed the State: Needs work PR awaiting additional work by the author to proceed label Sep 30, 2025
@racostas racostas self-requested a review October 6, 2025 17:17
racostas
racostas requested changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (and others comments) made last week are not yet solved. This PR is not ready to be "re-reviewed"

image

@christinerogers , @driusan

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Oct 6, 2025
racostas
racostas requested changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SKADE2303 , good advances.

Two things:

  • I seems the work OK is missing translation here:
image
  • This PR is deleting the test file modules/new_profile/test/NewProfileTestIntegrationTest.php , not sure the reason of it.

@christinerogers , @driusan

@racostas
Copy link
Contributor

racostas commented Oct 8, 2025 •
edited
Loading

Hi @SKADE2303 , good advances.

Two things:

  • I seems the work OK is missing translation here:
image * This PR is deleting the test file `modules/new_profile/test/NewProfileTestIntegrationTest.php` , not sure the reason of it.

@christinerogers , @driusan

If it is the case that in Hindi we use "OK" just this way- I have to confess I don't know - , anyways we should translate from OK to OK since not in all languages use "OK".

I took a second look and it seems this is deep in the swal library... not sure if we can in facts translate it. @SKADE2303, don't take care regarding the OK for the moment.... just address the test file been delete it.

@SKADE2303
Copy link
Contributor Author

SKADE2303 commented Oct 8, 2025

Hi @SKADE2303 , good advances.

Two things:

  • I seems the work OK is missing translation here:
image * This PR is deleting the test file `modules/new_profile/test/NewProfileTestIntegrationTest.php` , not sure the reason of it.

@christinerogers , @driusan

The OK's translation doesn't look module specific. I think it has to be done across all modules.
The test file got mixed up in a commit I wasn't supposed to push. Apologies

@racostas racostas requested review from driusan and racostas October 9, 2025 13:48
racostas
racostas approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is looking good to me now @driusan and @christinerogers.

I left you @driusan the final review. Thanks !!

@racostas racostas added Passed manual tests PR has been successfully tested by at least one peer and removed State: Needs work PR awaiting additional work by the author to proceed labels Oct 9, 2025
@driusan driusan merged commit 252052d into aces:main Oct 9, 2025
20 checks passed
@racostas racostas mentioned this pull request Oct 27, 2025
Merged
driusan pushed a commit that referenced this pull request Oct 29, 2025
@racostas
[new_profile - multilingual] Fixes translation of "OK" in swal messag…
1d4cb9b 
…e. (#10066)

- translate "OK" in the SWAL messages of new_profile
- Spanish language was use for demonstration purposes only. ( Also the
only Spanish translations included in the loris.po file were the ones
used in this module -- for simplicity and speeding the process)

Fixes #9900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@racostas racostas racostas approved these changes

@driusan driusan Awaiting requested review from driusan

Assignees

@racostas racostas

@SKADE2303 SKADE2303

Labels

Event: GSOC PR or issue accepted for Google Summer of Code Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: new_profile PR or issue related to new_profile module Multilingual Any tasks related to making LORIS multilingual Passed manual tests PR has been successfully tested by at least one peer State: Blocking PR should be prioritized because it is blocking the progress of another task

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SKADE2303 @driusan @christinerogers @racostas @kongtiaowang