Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling and fix docker compose #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aea7
Copy link

@aea7 aea7 commented Feb 11, 2023

Description

Discord username: aak#3635

closes #issue

Please see the issue for more information, feel free to push commits.

Things to do before you open the PR

  • I inspected and reviewed my own code.
  • If it's a core feature, I've ran detailed tests.

Rules for opening PR's

  • You must open a PR for an already existing issue. Otherwise the PR will be rejected.
  • Relevant issue number: Add the issue number in the '#issue' field below the discord username.
  • Clear and concise title: The PR title must be representative of the purposes and qualities of the actual code changes. It must be at the top of the comment. It must follow the semantic commit rules. For example: "docs(#issueId): Add README.md".
  • Relevant document choice: Only the relevant files must be changed and other files should remain untouched.
  • Formatting and Linting: Code must have been passed through the linters used by this repository.
  • Clean commit history: Commits with the changes need to be well ordered and descriptive.
  • Completed: PR should only be opened after the work is done, and must be sent to the other team members for review.

Changes

  • New Feature (Non-breaking)
  • New Refactor (Non-breaking performance or readability based changes)
  • Breaking change
  • Updated Docs

How were these changes tested?

local, run docker compose up and test the api

Test Configuration:

  • Firmware version: mac OS Ventura 13.0.1
  • Hardware: mac m1 pro
  • Toolchain:
  • SDK:

@giveerr giveerr added the kurala-uygun-pr bu pr pr açma kurallarına uygundur label Feb 11, 2023
@yusufgns yusufgns removed the kurala-uygun-pr bu pr pr açma kurallarına uygundur label Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: docker-compose not working, also error handling issue, as it returns empty JSON.
5 participants