Skip to content

NM-5857 | Replace all $ref tags with actual objects in private-network-service spec#1965

Open
saritathakur0 wants to merge 3 commits intoacquia:mainfrom
saritathakur0:NM-5857
Open

NM-5857 | Replace all $ref tags with actual objects in private-network-service spec#1965
saritathakur0 wants to merge 3 commits intoacquia:mainfrom
saritathakur0:NM-5857

Conversation

@saritathakur0
Copy link

Motivation

Fixes #NNN

Proposed changes

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. If running from source, clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Check for regressions: (add specific steps for this pr)
  4. Check new functionality: (add specific steps for this pr)

Copilot AI review requested due to automatic review settings February 18, 2026 14:22
@saritathakur0
Copy link
Author

Corresponding ax-api-spec PR - https://github.com/acquia/cx-api-spec/pull/393

ACLI commands working as expected -

~/Desktop/acquia_repo/cli/bin git:[main]
./acli api:private-networks:create --description="Private network for shcohort2vpc4" \
     --label="shcohort2vpc4:true" --isolation='{"dedicated_compute":true,"dedicated_network":true}' \
     --ingress='{"drupal_ssh":{"ingress_acls":["123.123.123.123/32"],"private":false}}' \
     2ca409cd-2018-42ca-b5a3-8d43c1acb6d7 us-east-1 shcohort2vpc4 \
     '{"cidr":"172.82.0.0/16","private_egress_access":{"drupal":true},"vpns":[{"name":"customersitevpn10","gateway_ip":"3.220.55.34","routes":["192.168.7.0/24"]}]}'
PHP Warning:  Module "grpc" is already loaded in Unknown on line 0

Warning: Module "grpc" is already loaded in Unknown on line 0
{
    "_links": {
        "self": {
            "href": "https:\/\/staging.cloud.acquia.com\/api\/private-networks\/0a8c108f-0dc0-4966-a09a-824a64b33fc6"
        }
    },
    "message": "Private network is being created"
}
~/Desktop/acquia_repo/cli/bin git:[main]
./acli api:private-networks:list
PHP Warning:  Module "grpc" is already loaded in Unknown on line 0

Warning: Module "grpc" is already loaded in Unknown on line 0

 ! [NOTE] subscriptionId is a required argument.                                                                        
 !                                                                                                                      
 !        ID of the subscription                                                                                        

 Enter a value for subscriptionId:
 >  2ca409cd-2018-42ca-b5a3-8d43c1acb6d7

[
    {
        "_links": {
            "connections": {
                "href": "https:\/\/staging.cloud.acquia.com\/api\/private-networks\/0a8c108f-0dc0-4966-a09a-824a64b33fc6\/connections"
            },
            "ingress": {
                "href": "https:\/\/staging.cloud.acquia.com\/api\/private-networks\/0a8c108f-0dc0-4966-a09a-824a64b33fc6\/ingress"
            },
            "isolation": {
                "href": "https:\/\/staging.cloud.acquia.com\/api\/private-networks\/0a8c108f-0dc0-4966-a09a-824a64b33fc6\/isolation"
            },
            "self": {
                "href": "https:\/\/staging.cloud.acquia.com\/api\/private-networks\/0a8c108f-0dc0-4966-a09a-824a64b33fc6"
            },
            "vpc_peers": {
                "href": "https:\/\/staging.cloud.acquia.com\/api\/private-networks\/0a8c108f-0dc0-4966-a09a-824a64b33fc6\/connections\/vpc-peers"
            },
            "vpns": {
                "href": "https:\/\/staging.cloud.acquia.com\/api\/private-networks\/0a8c108f-0dc0-4966-a09a-824a64b33fc6\/connections\/vpns"
            }
        },
        "created_at": "2026-02-18T14:00:07Z",
        "description": "Private network for shcohort2vpc4",
        "id": "0a8c108f-0dc0-4966-a09a-824a64b33fc6",
        "label": "shcohort2vpc4:true",
        "name": "shcohort2vpc4",
        "region": "us-east-1",
        "status": "creating",
        "subscription_id": "2ca409cd-2018-42ca-b5a3-8d43c1acb6d7",
        "updated_at": "2026-02-18T14:00:07Z"
    }
]
~/Desktop/acquia_repo/cli/bin git:[main]
./acli api:private-networks:find 0a8c108f-0dc0-4966-a09a-824a64b33fc6
PHP Warning:  Module "grpc" is already loaded in Unknown on line 0

Warning: Module "grpc" is already loaded in Unknown on line 0
{
    "_links": {
        "connections": {
            "href": "https:\/\/staging.cloud.acquia.com\/api\/private-networks\/0a8c108f-0dc0-4966-a09a-824a64b33fc6\/connections"
        },
        "ingress": {
            "href": "https:\/\/staging.cloud.acquia.com\/api\/private-networks\/0a8c108f-0dc0-4966-a09a-824a64b33fc6\/ingress"
        },
        "isolation": {
            "href": "https:\/\/staging.cloud.acquia.com\/api\/private-networks\/0a8c108f-0dc0-4966-a09a-824a64b33fc6\/isolation"
        },
        "self": {
            "href": "https:\/\/staging.cloud.acquia.com\/api\/private-networks\/0a8c108f-0dc0-4966-a09a-824a64b33fc6"
        },
        "vpc_peers": {
            "href": "https:\/\/staging.cloud.acquia.com\/api\/private-networks\/0a8c108f-0dc0-4966-a09a-824a64b33fc6\/connections\/vpc-peers"
        },
        "vpns": {
            "href": "https:\/\/staging.cloud.acquia.com\/api\/private-networks\/0a8c108f-0dc0-4966-a09a-824a64b33fc6\/connections\/vpns"
        }
    },
    "created_at": "2026-02-18T14:00:07Z",
    "description": "Private network for shcohort2vpc4",
    "id": "0a8c108f-0dc0-4966-a09a-824a64b33fc6",
    "label": "shcohort2vpc4:true",
    "name": "shcohort2vpc4",
    "region": "us-east-1",
    "status": "active",
    "subscription_id": "2ca409cd-2018-42ca-b5a3-8d43c1acb6d7",
    "updated_at": "2026-02-18T14:07:32Z"
}

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@danepowell danepowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR; we can merge this as soon as the upstream PR is merged (assuming the generated spec is identical; I haven't checked)

Copy link
Contributor

@Roy19 Roy19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants