Implement tBTC Bridge fees reimbursement #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For deposits below a certain threshold, the fees will be reimbursed from the fees reimbursement pool, funded by the Acre protocol. The tBTC Bridge fees reimbursement threshold can be updated by the Acre protocol owner.
✅ Deploy Preview for acre-dapp-testnet canceled.
|
✅ Deploy Preview for acre-dapp canceled.
|
r-czajkowski
reviewed
May 8, 2025
Comment on lines
49
to
57
| uint256 availableBalance = IERC20(tbtcToken).balanceOf(address(this)); | ||
|
|
||
| if (availableBalance < reimbursedAmount) { | ||
| reimbursedAmount = availableBalance; | ||
| } | ||
|
|
||
| if (reimbursedAmount > 0) { | ||
| IERC20(tbtcToken).safeTransfer(msg.sender, reimbursedAmount); | ||
| } |
There was a problem hiding this comment.
Because there is some logic to calculate the reimbursed amount (I mean, in some cases the full amount cannot be covered), maybe we can create a view function so we can call it in SDK and use it in this function?
There was a problem hiding this comment.
For the dApp it should be enough to check the FeesReimbursementPool contract balance. We will need to think about a value below which we won't show the info about fee reimbursements in the UI. Since the bridging operation is asynchronous, there will be a delay between the moment the user initiates a deposit in the UI and when the bridging is finalized and the fee is reimbursed.
It is not required to initialize the value as 0 is the default value anyway.
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This contract has to be updated with the recent changes in the BitcoinDepositor contract.
nkuba
force-pushed
the
deposit-fees-reimbursement
branch
from
5b2f253 to
831ef55
Compare
This function allows to update the fees reimbursement pool address.
This commit adds unit tests for new setters added to the BitcoinDepositor contract.
The deposit amount for reimbursement is inclusive of the threshold amount.
Check if fees reimbursement pool is set before calling reimburse function to avoid meaningless revert.
Tests assume this reference is returned but it was not. This change should fix the tests.
Return Withdrawn and Reimbursed events from appropriate functions. In theory, we could track it with tBTC Transfer events but in practice, more specific events make state change tracking much easier.
A complete set of unit tests for FeesReimbursementPool contract.
Check if the provided tBTC and BitcoinDepositor contract addresses are non-zero when the FeesReimbursementPool contract is initialized.
Dropped the "copy" suffix from the file name. Something committed accidentally in the past.
The FeesReimbursementPool address in the BitcoinDepositor can be set by the script only on Hardhat network. On all other networks it has to be done manually by the governance. Accepting ownership of FeesReimbursementPool can only happen on Hardhat network. On all other networks, the governance address need to call this function and the governance is either external EOA (Sepolia) or a multisig (Ethereum mainnet).
The function returns a value that has been actually reimbursed, which is important to use in integration with the FeesReimbursementPool contract.
pdyraga
reviewed
Jun 17, 2025
This is a pattern we use across the file.
pdyraga
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For deposits below a certain threshold, the fees will be reimbursed from the fees reimbursement pool, funded by the Acre protocol.
The tBTC Bridge fees reimbursement threshold can be updated by the Acre protocol owner.