-
Notifications
You must be signed in to change notification settings - Fork 4
Allocator contract for deposits into the Midas Vault #947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The contract is extracted from the MezoAllocator contract. It contains parts related to the maintainer roles.
…location The MidasAllocator contract is a simple allocator that deposits tBTC to the Midas Vault and holds the shares minted by the Vault. The Vault is expected to be implemented by the Midas team according to the IVault interface, to wrap their own vault contracts. As their setup uses two distinct vaults for deposits and redemptions, in addition to a separate shares token contract. This implementation doesn't cover the withdrawal functionality, as it will be built on top of the queued withdrawals functionality.
The scripts deploy the MidasAllocator contract and update the stBTC contract to use the new allocator.
tbtc.balanceOf(address(stbtc)) | ||
); | ||
|
||
// TODO: Revisit when working on queued withdrawals as part of the balance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
queued withdrawals will be handled in different contract so not relavant anymore cause this contract won't hold withdrawn assets from midas anymore @nkuba
The MidasAllocator contract is a simple allocator that deposits tBTC to the
Midas Vault and holds the shares minted by the Vault.
The Vault is expected to be implemented by the Midas team according to the
IVault interface, to wrap their own vault contracts. As their setup uses two
distinct vaults for deposits and redemptions, in addition to a separate shares
token contract.
This implementation doesn't cover the withdrawal functionality, as it will
be built on top of the queued withdrawals functionality.