-
Notifications
You must be signed in to change notification settings - Fork 19
Don't require a key to install cached program #125
base: master
Are you sure you want to change the base?
Conversation
With the runner name and the program version a unique key can already be generated
I'm very unsure, if using |
You could use the |
The |
@thomaseizinger Was there any feedback to @flip1995's comment about runner? I'm interested in keeping this moving so that actions-rs/install#5 can keep moving. I'm not highly experienced with github actions, but I'm willing to help in any way I can to keep things going. |
Nope, as @flip1995 correctly pointed out, the |
FWIW my read is that using platform+release+arch from OS should cover all the variations that exist (linux vs windows, 32-bit vs 64-bit, arm64 vs. x86-64). |
Any update here? would be great if this could move forward for the PRs that depend on this change |
No updates from my side. This is still waiting for review. All the projects I'm involved in moved away from using actions-rs actions though. I'm still willing to finish this PR, but without a review there's nothing much I can do here. |
Friendly ping @svartalf: This PR and the actions-rs/install#5 PR are waiting for your review. Can you give us an update, if you are able to review this in the future? Since there was no update to this repo in over 1 year, I assume you stopped maintaining the actions-rs repositories. If so, please let us know so that we can explore alternatives. |
With the runner name and the program version a unique key can already be generated.
TODO: How to get the runner name? @svartalfI now use
os.{platform,release,arch}()
to determine the runner. I'm not sure if this is robust enough to prevent problems.(This also improves the documentation)
This PR is necessary for actions-rs/install@57e52b9