feature: add support for commit
input (fixes #1634)
#1858
+47
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1634
This pull request adds support for supplying a commit input. This is necessary in order to replicate the standard behavior in pull request synchronization events when not using the default values.
commit
input in theaction.yaml
fileinput-helper
file, beforesettings.ref
is checked and assigned default values, setsettings.commit
to equal theinputs.commit
.input-helper
file, changesettings.ref = core.getInput('ref')
tosettings.ref = core.getInput('ref') ?? settings.ref
as a fallback for when thecommit
input was specified, but not theref
input.settings.ref
fallback tosettings.commit
, validate that thesettings.commit
, if defined, has the format of a full SHA sum.npm run format
npm run build
input-helper
, change thesettings.ref
fallback from using??
to||
, becuasesettings.ref
might be an empty string or null, causing??
to not have the desired effect. Also updated the test to reflect the fallback behavior.