Skip to content

Simplify Packer templates for Windows and Ubuntu images #12522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

feliasson
Copy link

Description

Reference: #12305

I like this refactor but can we please stop introducing new ways of referencing the same image to generate.
The goal here is consistency, and reusing the same approach for referencing images helps maintain that across the codebase.

In this I am simply reusing ImageType as input for the image_os variable, which is used in the new map in locals, instead of adding extra code and creating a new reference for the same image type.

Current reference examples for image

Windows2025
windows-2025
win25
Ubuntu2404
ubuntu-24_04
ubuntu24

I’ll leave this PR as an example of an approach that avoids introducing additional references and aims to stay more consistent. Please consider.

Related issue:

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@feliasson feliasson marked this pull request as ready for review July 3, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant