Simplify Packer templates for Windows and Ubuntu images #12522
+9
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reference: #12305
I like this refactor but can we please stop introducing new ways of referencing the same image to generate.
The goal here is consistency, and reusing the same approach for referencing images helps maintain that across the codebase.
In this I am simply reusing
ImageType
as input for theimage_os
variable, which is used in the new map inlocals
, instead of adding extra code and creating a new reference for the same image type.Current reference examples for image
I’ll leave this PR as an example of an approach that avoids introducing additional references and aims to stay more consistent. Please consider.
Related issue:
Check list