Skip to content

Conversation

YannickRe
Copy link

Description

Bug fixing. Adjust the logic of dealing with Tags in a way that is an exact copy of the logic within GenerateResourcesAndImage.ps1 . This solves a parsing error.

Related issue:

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

Adjust the logic of dealing with Tags in a way that is an exact copy of the logic within GenerateResourcesAndImage.ps1 . This solves a parsing error.
@Copilot Copilot AI review requested due to automatic review settings August 15, 2025 23:38
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a parsing error by aligning the tag handling logic with the implementation from GenerateResourcesAndImage.ps1. The change ensures proper JSON escaping of tags based on the PowerShell version being used.

  • Updates tag processing to handle JSON escaping properly across different PowerShell versions
  • Replaces direct JSON conversion with version-specific string escaping logic
  • Renames the variable from azure_tags to TagsJson for clarity

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@YannickRe
Copy link
Author

Copilot is being stupid here, the point is to do that exact string replacement...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant