[Windows] Several fixes for the SSH known_hosts files #13154
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Ensure the ssh_known_hosts files are plain-text with no BOM Powershell's redirect was creating a file with UTF16 encoding. 1. Create a ssh_known_hosts file for the ssh application included with Windows. 1. Use ssh-keyscan from the Git for Windows installation so keys from github.com can be added. Relates to actions#13072
tvalenta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bugfix and improvement on the ssh host keys for GitHub and Azure that are added to Windows images.
Related issue: #13072
Check list