Skip to content

Conversation

@priyagupta108
Copy link
Contributor

@priyagupta108 priyagupta108 commented Nov 19, 2025

Description:
This pull request removes support for the always-auth input from the action, as it is deprecated in modern versions of npm and is no longer required for current authentication workflows. This update streamlines the action and ensures alignment with modern best practices.

Related issue:
#1305

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

priyagupta108 and others added 3 commits November 11, 2025 15:42
Update README to mention removal of always-auth input
Updated the description of the 'always-auth' input removal for clarity.
@priyagupta108 priyagupta108 requested a review from a team as a code owner November 19, 2025 05:50
Copilot AI review requested due to automatic review settings November 19, 2025 05:50
Copilot finished reviewing on behalf of priyagupta108 November 19, 2025 05:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes the deprecated always-auth input from the setup-node action, as it is no longer supported in modern npm versions. This cleanup streamlines the action and aligns it with current npm best practices.

  • Removed always-auth parameter from authentication configuration functions
  • Updated all test files to remove always-auth references
  • Updated documentation to notify users of this breaking change

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/main.ts Removed alwaysAuth input retrieval and parameter passing to configAuthentication()
src/authutil.ts Removed alwaysAuth parameter from configAuthentication() and writeRegistryToFile() functions, and removed generation of always-auth line in .npmrc file
dist/setup/index.js Updated compiled JavaScript to match source code changes
action.yml Removed always-auth input definition from action configuration
tests/authutil.test.ts Updated test expectations to not check for always-auth in generated .npmrc files and removed test case specifically for always-auth=true
tests/rc-installer.test.ts Removed always-auth input from test setup
tests/official-installer.test.ts Removed always-auth input from test setup
tests/nightly-installer.test.ts Removed always-auth input from test setup
tests/canary-installer.test.ts Removed always-auth input from test setup
docs/advanced-usage.md Removed documentation section explaining the always-auth input
README.md Added breaking change notice for V6 about always-auth removal and removed always-auth from usage examples

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants