-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Remove always-auth configuration handling from action #1436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update README to mention removal of always-auth input
Updated the description of the 'always-auth' input removal for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request removes the deprecated always-auth input from the setup-node action, as it is no longer supported in modern npm versions. This cleanup streamlines the action and aligns it with current npm best practices.
- Removed
always-authparameter from authentication configuration functions - Updated all test files to remove
always-authreferences - Updated documentation to notify users of this breaking change
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main.ts | Removed alwaysAuth input retrieval and parameter passing to configAuthentication() |
| src/authutil.ts | Removed alwaysAuth parameter from configAuthentication() and writeRegistryToFile() functions, and removed generation of always-auth line in .npmrc file |
| dist/setup/index.js | Updated compiled JavaScript to match source code changes |
| action.yml | Removed always-auth input definition from action configuration |
| tests/authutil.test.ts | Updated test expectations to not check for always-auth in generated .npmrc files and removed test case specifically for always-auth=true |
| tests/rc-installer.test.ts | Removed always-auth input from test setup |
| tests/official-installer.test.ts | Removed always-auth input from test setup |
| tests/nightly-installer.test.ts | Removed always-auth input from test setup |
| tests/canary-installer.test.ts | Removed always-auth input from test setup |
| docs/advanced-usage.md | Removed documentation section explaining the always-auth input |
| README.md | Added breaking change notice for V6 about always-auth removal and removed always-auth from usage examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description:
This pull request removes support for the
always-authinput from the action, as it is deprecated in modern versions of npm and is no longer required for current authentication workflows. This update streamlines the action and ensures alignment with modern best practices.Related issue:
#1305
Check list: