feat(code-scanning): Update Trivy starter workflows

[simar7]

Description

This PR updates the Trivy workflows to the latest recommended workflow examples. Also deprecates the tfsec workflow as we've integrated its functionality into Trivy.

Signed-off-by: Simar simar@linux.com

Pre-requisites

• Prior to submitting a new workflow, please apply to join the GitHub Technology Partner Program: partner.github.com/apply.

---

Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.

---

Tasks

For all workflows, the workflow:

• Should be contained in a .yml file with the language or platform as its filename, in lower, kebab-cased format (for example, docker-image.yml). Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").
• Should use sentence case for the names of workflows and steps (for example, "Run tests").
• Should be named only by the name of the language or platform (for example, "Go", not "Go CI" or "Go Build").
• Should include comments in the workflow for any parts that are not obvious or could use clarification.
• Should specify least privileged permissions for GITHUB_TOKEN so that the workflow runs successfully.

For CI workflows, the workflow:

• Should be preserved under the ci directory.
• Should include a matching ci/properties/*.properties.json file (for example, ci/properties/docker-publish.properties.json).
• Should run on push to branches: [ $default-branch ] and pull_request to branches: [ $default-branch ].
• Packaging workflows should run on release with types: [ created ].
• Publishing workflows should have a filename that is the name of the language or platform, in lower case, followed by "-publish" (for example, docker-publish.yml).

For Code Scanning workflows, the workflow:

• Should be preserved under the code-scanning directory.
• Should include a matching code-scanning/properties/*.properties.json file (for example, code-scanning/properties/codeql.properties.json), with properties set as follows:
  • name: Name of the Code Scanning integration.
  • creator: Name of the organization/user producing the Code Scanning integration.
  • description: Short description of the Code Scanning integration.
  • categories: Array of languages supported by the Code Scanning integration.
  • iconName: Name of the SVG logo representing the Code Scanning integration. This SVG logo must be present in the icons directory.
• Should run on push to branches: [ $default-branch, $protected-branches ] and pull_request to branches: [ $default-branch ]. We also recommend a schedule trigger of cron: $cron-weekly (for example, codeql.yml).

Some general notes:

• This workflow must only use actions that are produced by GitHub, in the actions organization, or
• This workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be published to the GitHub Marketplace. We require that these actions be referenced using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file:

  # This workflow uses actions that are not certified by GitHub.
  # They are provided by a third-party and are governed by
  # separate terms of service, privacy policy, and support
  # documentation.
  

• Automation and CI workflows should not send data to any 3rd party service except for the purposes of installing dependencies.
• Automation and CI workflows cannot be dependent on a paid service or product.

[Copilot]

Pull Request Overview

This PR updates the Trivy starter workflows for Code Scanning by introducing a new repository vulnerability scan workflow, updating the IaC scan workflow to the latest recommended examples, and deprecating the tfsec workflow.

• Adds code-scanning/trivy-vulnerability-scan.yml for repo vulnerability scanning.
• Updates code-scanning/trivy-iac-scan.yml with a more descriptive name, explicit OS version, and revised Trivy action version.
• Removes the deprecated tfsec.yml workflow.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
code-scanning/trivy-vulnerability-scan.yml	New workflow for running Trivy vulnerability scans in repository (fs) mode.
code-scanning/trivy-iac-scan.yml	Updated workflow for running Trivy IaC scans with revised parameters and OS version.
code-scanning/tfsec.yml	Deprecated tfsec workflow has been removed.

Comments suppressed due to low confidence (2)

code-scanning/trivy-iac-scan.yml:6

• [nitpick] Consider verifying that including 'IaC' in the workflow name aligns with our naming convention, which generally uses only the language or platform name.

name: Trivy IaC Scan

code-scanning/trivy-iac-scan.yml:33

• Ensure that version 0.30.0 of the Trivy action has been fully verified with these workflow settings, as the action behavior and supported flags may have changed from previous versions.

uses: aquasecurity/trivy-action@0.30.0

[simar7]

@DanRigby I'm not sure whose the right person to ask but is it possible if we could approve and merge this if it looks good to the team?

[jsoref]

If you use github/codeql-action/upload-sarif (which this workflow does) and your workflow yields a failure (which the exit-code: 1 would if I'm reading the docs correctly), then github's sarif stuff will say your workflow is broken, so you don't want to report an error via the workflow, instead you want to report things via upload-sarif and tell people to use a ruleset.

I describe this in my (check-spelling v0.0.25 release notes](https://github.com/check-spelling/check-spelling/releases/tag/v0.0.25): Code Scanning action requires a Code Scanning Ruleset

I think this is correct:

Suggested change

	exit-code: '1'
	severity: 'CRITICAL,HIGH'
	- name: Upload Trivy scan results to GitHub Security tab
	uses: github/codeql-action/upload-sarif@v3
	if: always()
	exit-code: '0'
	severity: 'CRITICAL,HIGH'
	- name: Upload Trivy scan results to GitHub Security tab
	uses: github/codeql-action/upload-sarif@v3