draft: implemented alternative protobuf implementation#274
Closed
tmk241 wants to merge 2 commits intoactix:mainfrom
Closed
draft: implemented alternative protobuf implementation#274tmk241 wants to merge 2 commits intoactix:mainfrom
tmk241 wants to merge 2 commits intoactix:mainfrom
Conversation
robjtede
added
A-protobuf
tmk241
force-pushed
the
alternative-protobuf-implementation
branch
from
43efb3f to
1780f7e
Compare
tmk241
force-pushed
the
alternative-protobuf-implementation
branch
from
d660ebf to
f13a001
Compare
JohnTitor
reviewed
Feb 8, 2026
| let res = ready!(Pin::new(&mut *payload).poll_next(cx)); | ||
| match res { | ||
| Some(chunk) => { | ||
| let chunk = chunk.unwrap(); |
Member
There was a problem hiding this comment.
I guesss this unwrap could be risky.
| Body { | ||
| limit: usize, | ||
| length: Option<usize>, | ||
| #[cfg(feature = "__compress")] |
Member
|
Sorry for the late review. I think the current rewrite isn't production-ready and needs some major follow-ups. Since this patch is now outdated, I'd like to see the latest form of the patch rebased onto the main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Refactor
PR Checklist
cargo +nightly fmt).Overview
Generally I'd like to discuss whether a ProtoBuf implementation for actix should be closer to the existing JSON implementation.
Original JSON implementation
For that reason I created this alternative ProtoBuf implementation.
Since I'm rather new to programming in Rust I'd definitely love to hear your inputs on this.
I guess there might be some pitfalls I'm unaware of! 😄
Thanks for having a look