Upstream tracing-actix-web into actix-extras#468
Closed
LukeMathWalker wants to merge 171 commits intoactix:masterfrom
Closed
Upstream tracing-actix-web into actix-extras#468LukeMathWalker wants to merge 171 commits intoactix:masterfrom
tracing-actix-web into actix-extras#468LukeMathWalker wants to merge 171 commits intoactix:masterfrom
Conversation
fix missing tracing-log import in Readme
* Make request ID extractable in request handlers * Remove unnecessary clone * Implement `Display`, `Deref` and `Into` for RequestId * Derive `Copy` for `RequestId` since `Uuid` is `Copy` * Document `RequestId` * Clarify, when the ID is logged Co-authored-by: Valentin Brandl <mail+dev@vbrandl.net>
Co-authored-by: LukeMathWalker <contact@palmieri.com>
* Add http.route. * Align all fields with OpenTelemetry's semantic conventions. * Add span kind. * Emit event for errors. Add OTEL status code. * Create otel.status_code field as empty. * Fix errors. * Add (feature-gated) support for OpenTelemetry span propagation. * Capture the trace id as an attribute on the span. * Change message. * Log the newly-generated trace id if there is no parent context. * Define a root_span macro as a stepping stone to allow crate users to add their own fields to the root span. * Add comments. * mut is no longer necessary. * Allow users to customise generation of the root span. Split recording fields on span end from emission of log record. Make log record on error optional via feature flag. * Provide constructor + default implementation. * Explode into multiple modules. Fix various paths/private imports in root_span. * Rename module to root_span_macro. * Add a new extractor to retrieve the root span. * Document crate. * Docs! * Add section on OTEL. * Mention actix-web-opentelemetry. * Add OpenTelemetry example. * Improve readme. * Add custom root span example. Co-authored-by: LukeMathWalker <contact@palmieri.com>
* Add examples links. * Bump minor version. * Add note on version. * Update README. * Add badges. * Add license blurb.
* Support otel 0.22 * Update Cargo.toml * Fix examples * revert needed spaces at EOLs
* Support otel 0.24 * fix the otel example * Fix examples and last bits * Update examples/custom-root-span/src/main.rs * Update examples/opentelemetry/src/main.rs --------- Co-authored-by: Luca Palmieri <20745048+LukeMathWalker@users.noreply.github.com>
LukeMathWalker
force-pushed
the
tracing-actix-web
branch
2 times, most recently
from
2750ee8 to
f0669d2
Compare
Contributor
Author
|
There's a few failing jobs:
Let me know how you want to move forward on the first one. |
LukeMathWalker
force-pushed
the
tracing-actix-web
branch
from
f0669d2 to
013c535
Compare
Member
|
@LukeMathWalker 👋 Sorry for the delay! Are you still interested in this request? I see you've continued maintaining the original repo and want to make sure you still want to do it :) |
Contributor
Author
|
Still happy to see it upstreamed, although I don't have time to work on it myself. |
Member
|
@LukeMathWalker I've merged the repo as subtree in #615! |
Member
|
@LukeMathWalker Just following-up on this: we're ready to cut a new release for transition but need an invite on crates.io. |
Contributor
Author
Sorry for the delay, just sent it! |
Member
|
Thank you! Confirmed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to preserve the
githistory to give proper attribution to historical contributors totracing-actix-web.I've had to do some adjustments to your CI setup to account for
tracing-actix-web's mutually exclusive features.