ref: Use type registry for io type mapping #1085
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
force-pushed
the
ref-io-type-mapping
branch
2 times, most recently
from
eaa961c to
ec97c6b
Compare
niermann999
force-pushed
the
ref-io-type-mapping
branch
from
ec97c6b to
9e6a7a2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a template specialization for every mapped type, use the mapped type registry to automatize the type mapping at compile time. In order to make new shapes known to the IO system, an ID and the type need to be added to the frontend io definitions header. The id enum and type will then be automatically mapped to the id a detector type is using (unknown_type if the type is not included in the given detector).
Also fixes the shape and frame concepts to include 3-dimensional shapes