Skip to content

Conversation

@niermann999
Copy link
Collaborator

Implement annulus check from global coordinates

@niermann999 niermann999 added the performance Improvements to compute performance label Dec 8, 2025
@niermann999
Copy link
Collaborator Author

Main:

BM_MASK_RECTANGLE_2D                                1146 ms         1144 ms            1
BM_MASK_CONCENTRIC_CYLINDER_2D                       644 ms          642 ms            1
BM_MASK_ANNULUS_2D                                 18729 ms        18697 ms            1

This PR:

BM_MASK_RECTANGLE_2D                                1151 ms         1149 ms            1
BM_MASK_CONCENTRIC_CYLINDER_2D                       644 ms          642 ms            1
BM_MASK_ANNULUS_2D                                  9597 ms         9580 ms            1

@niermann999 niermann999 marked this pull request as ready for review December 8, 2025 16:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

@niermann999 niermann999 enabled auto-merge (squash) December 8, 2025 17:09
@niermann999 niermann999 merged commit ce40d8c into acts-project:main Dec 8, 2025
19 of 21 checks passed
@paulgessinger
Copy link
Member

paulgessinger commented Dec 8, 2025

Does this work when the surface is rotated?

Never mind found it.

I think you mostly gain from early rejections if you're outside of the radius. Do you know how much of the benchmark is from points like that?

@niermann999
Copy link
Collaborator Author

Does this work when the surface is rotated?

Never mind found it.

I think you mostly gain from early rejections if you're outside of the radius. Do you know how much of the benchmark is from points like that?

Without the early rejection, the benchmark was at about 14xxx ms, but I don't quite remember the exact number now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Improvements to compute performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants