Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Switch the old toy detector against the new in all detray tests and benchmarks #705

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

niermann999
Copy link
Contributor

Switch the old toy detector against the new in all detray tests and benchmarks. The tests for the old toy detector are removed, but the create_toy_detector header is kept, until all tests in traccc pass

@niermann999 niermann999 force-pushed the feat-new-toy-det branch 3 times, most recently from 8512f5e to 672dd61 Compare March 20, 2024 01:30
@niermann999
Copy link
Contributor Author

Most of the changes come from renaming create_toy_geometry to build_toy_detector

Copy link
Collaborator

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow all the changes in the volume and surface index but I believe you

@niermann999 niermann999 merged commit d493e69 into acts-project:main Mar 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants