Skip to content

Commit

Permalink
Merge pull request #338 from guilhermeAlmeida1/fixIntelGPUCompatibili…
Browse files Browse the repository at this point in the history
…tyBarrier

Remove return in CCL_kernel
  • Loading branch information
krasznaa authored Mar 9, 2023
2 parents 36fbe79 + 07fe7e9 commit c416be1
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions device/sycl/src/clusterization/clusterization_algorithm.sycl
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,8 @@ class ccl_kernel {
unsigned char adjc[MAX_CELLS_PER_THREAD];

// It seems that sycl runs into undefined behaviour when calling
// any_of_group when some threads have already run into a return. So can
// only do this after running the FastSV algorithm.
// group synchronisation functions when some threads have already run
// into a return. As such, we cannot use returns in this kernel.

#pragma unroll
for (index_t tst = 0; tst < MAX_CELLS_PER_THREAD; ++tst) {
Expand Down Expand Up @@ -295,11 +295,6 @@ class ccl_kernel {

item.barrier();

// Now that we can use return, check if any work needs to be done
if (tid >= size) {
return;
}

/*
* Count the number of clusters by checking how many cells have
* themself assigned as a parent.
Expand Down

0 comments on commit c416be1

Please sign in to comment.